Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Inspec to NIST 800-53 Mapper Abstractions #4

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tohch4
Copy link
Contributor

@tohch4 tohch4 commented Jan 27, 2021

Fixes #3.

@tohch4 tohch4 requested a review from gregelin January 27, 2021 00:57
Copy link
Contributor

@gregelin gregelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@aaronlippold
Copy link

also, the name control_id for the nist control may be confusing.
I would suggest we use something like nist_control to be clear as inspec using the term control id as part of its schema.

@tohch4
Copy link
Contributor Author

tohch4 commented Jan 27, 2021

also, the name control_id for the nist control may be confusing.
I would suggest we use something like nist_control to be clear as inspec using the term control id as part of its schema.

I can agree it's confusing, but I was trying to explain it from the perspective and shape of Inspec data, maybe that is a little misguided. I was thinking of something like tag_filter or control_family_tag to make it clear "what" in Inspec maps to "what" in OSCAL. Would love more feedback like this. Keep it coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Inspec to NIST 800-53 Mapper
3 participants