Indent each line of error messages #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By indenting each line instead of just the first, we simplify the work of the gf-lsp parser, so we can see which errors are the same
There are no longer any gihub actions runners available for these Note that this means we can't build for ubuntu-18 anymore, but that should hopefully no longer be relevant, since it's over 5 years old now.
cibuildwheel requires python >= 3.8
anka-213
changed the title
|
I added commits to disable the platforms that github no longer has runners available for, to fix the stuck CI actions. I also made the build CI actions faster by making them not build gf an extra time just for the tests. This has cut the CI time for the stack builds roughly in half, from 18 minutes to 9 minutes (or 2 hours cpu time vs 1 hour cpu time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the first line of an error message was indented.
Changing this makes the error messages easier to parse, both for humans and machines. In addition to looking better it would also help making it easier for gf-lsp to show the errors at the correct location
Before:
After