Added an internal OR switch to every drawstop #2012
Conversation
There was a problem hiding this comment.
The action build show that this PR causes at least switch drawstops to not function correctly. When the drawstop gets active no sound is produced, but when it's deactivated again sound output happens even though the drawstop is off! When the drawstop is visibly active no sound is emitted. In other words after first activation/de-activation they are reversed!
A few of the affected sample sets are Bureå Church, Bygdsiljum Church and Norrfjärden Church.
Older sample sets that directly use/display the stop seems to function normally though.
On a side note, I have no problem with introducing this feature to fix the original issue with the crescendo - that is, when everything actually is working! However, I'm not convinced that exposing this internal OR in any way (ODF) is a good idea - which I understood from another discussion that you eventually intend to do.
oleg68
force-pushed
the
feature/combination-state-name
branch
from
3f1c69b to
84cf264
Compare
|
@larspalo I fixed the behavior of AND switches. |
|
@rousseldenis could you approve this PR? |
This is the second PR related to #1935
It adds an internal
ORswitch to every drawstop. The switch has several named entries. The default entry has an wxEmptyString name.When any of drawstop switches named entry is activated, the drawstop is also activated. When all of the entries are deactivated the drawstop is also deactivated.
Now this capability is not used and it will be used in a future PR for the Add mode of Crescendo.
So no GO behavior should be used now.