Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored GOMidiPlayer for playing midi events though GOMidi instead of GOMOrganController #2040

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Nov 9, 2024

Earlier GOMidiPlayer used GOOrganController::ProcessMidi for playing midi events. It caused that the Log Midi Events did not log events from a midi file.

This PR

  • Introduces the new method GOMidi::PlayMidiEvent for the signge entry point for all events either from a midi devices or fom a midi file
  • Now GOMidiPlayer uses GOMidi::PlayMidiEvent instead of GOOrganController::ProcessMidi
  • Eliminates most of usages of GOOrganController in GOMidiPlayer
  • Starts logging midi events when they are played from a midi file

@oleg68 oleg68 mentioned this pull request Nov 10, 2024
4 tasks
@oleg68
Copy link
Contributor Author

oleg68 commented Nov 15, 2024

@rousseldenis Could you approve this PR?

@oleg68 oleg68 merged commit ee3a926 into GrandOrgue:master Nov 18, 2024
1 check passed
@oleg68 oleg68 deleted the refactor/midi-player branch November 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants