Fixed not releasing a pipe after fast switching between vave-based tremulant samples and regular pipe samples https://github.com/GrandOrgue/grandorgue/issues/2004

[oleg68]

Resolves: #2004

It resolves the issue with the midi file from #2004 (comment)

The reason was GOSoundFader: when a sampler was in "increasing" crossfade state and then it was switched to another attack (with the wave-based tremulants on/off), the old attack sample was never released and sounded infinitelly.

[oleg68]

Seems this change breaks playing release samples. I need more time to work.

[oleg68]

I reworked GOSoundFaded and the fix.

Earlier increasing and decreasing the volume were in place together so might interfere and the sample was neve released
After the first my fix decreasing discarded increasing so a release sample (that always started from 0 due the crossfade) was not played if The ReleaseLength was set to any value rather the Max.
Now decreasing becomes "virtual" until the increased and decreased target volumes meet at the new target volume.

[hnb2907]

Nice one 👍Your description sounds promising 🙂

Could you point me to the binary please? Hopefully I will be able to try it later today or tomorrow.

Cheers, Chris.

[oleg68]

Could you point me to the binary please?

https://github.com/oleg68/GrandOrgue-official/actions/runs/11785207053

[oleg68]

@larspalo @rousseldenis Could you approve this PR?

[oleg68]

@larspalo @rousseldenis As talked in #2004, the last intermediate build fixed all pipe-attack and pipe-release isuues mentioned there. The final variant can be taken for tests from https://github.com/oleg68/GrandOrgue-official/actions/runs/12072896654

Could you approve this PR?

[oleg68]

@rousseldenis Pourriez-vous approuver ce PR? Merci.

[oleg68]

@rousseldenis I'm going to merge this PR as administrator without your approving. Do you agree or disagree?