Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganised prepare scripts for tests #2070

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Dec 13, 2024

This PR

  • moves installing cpptrace to a separate script prepare-cpptrace.bash
  • removes the special script prepare-debian-for-tests.sh
  • added the steps necessary for tests to the normal installation scripts prepare-debian-based.sh and prepare-fedora.sh

@larspalo
Copy link
Contributor

I'm not fond of adding this downloading and building of a third party software as a requirement as the tests are (and should always be) optional.

@rousseldenis
Copy link
Contributor

I'm not fond of adding this downloading and building of a third party software as a requirement as the tests are (and should always be) optional.

Yes, at least that should be optional when wanting to run tests. That was the philosophy before this.

@oleg68 oleg68 force-pushed the refactor/prepare-for-tests branch from 95382ea to 7983607 Compare December 14, 2024 15:03
@oleg68
Copy link
Contributor Author

oleg68 commented Dec 14, 2024

@larspalo @rousseldenis Now by the testing software is not installed unless the tests parameter is passed

@oleg68 oleg68 mentioned this pull request Dec 14, 2024
2 tasks
@oleg68 oleg68 merged commit f473da6 into GrandOrgue:master Dec 20, 2024
1 check passed
@oleg68 oleg68 deleted the refactor/prepare-for-tests branch December 20, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants