Eliminated a MacOs debug alert when opening a settings dialog #2003

CHANGELOG.md

@@ -1,3 +1,4 @@
+- Eliminated a MacOs debug alert when opening a settings dialog https://github.com/GrandOrgue/grandorgue/issues/2003
 - Fixed not releasing a pipe after fast switching between vave-based tremulant samples and regular pipe samples https://github.com/GrandOrgue/grandorgue/issues/2004
 - Removed support of MacOs 12
 - Fixed hang if there were lots of unused ODF entries https://github.com/GrandOrgue/grandorgue/issues/1918

src/grandorgue/gui/dialogs/settings/GOSettingsPorts.cpp

@@ -1,6 +1,6 @@
 /*
  * Copyright 2006 Milan Digital Audio LLC
- * Copyright 2009-2023 GrandOrgue contributors (see AUTHORS)
+ * Copyright 2009-2024 GrandOrgue contributors (see AUTHORS)
  * License GPL-2.0 or later
  * (https://www.gnu.org/licenses/old-licenses/gpl-2.0.html).
  */
@@ -94,12 +94,13 @@ void GOSettingsPorts::FillPortsWith(const GOPortsConfig &config) {
   m_Ports->DeleteAllItems();
 
   for (const wxString &portName : m_PortFactory.GetPortNames()) {
+    const bool isToShowPort = m_PortFactory.IsToUsePortName();
     const wxTreeListItem &rootItem = m_Ports->GetRootItem();
-    const wxTreeListItem &portItem = m_PortFactory.IsToUsePortName()
-      ? AddPortItem(rootItem, portName)
-      : rootItem;
+    const wxTreeListItem &portItem
+      = isToShowPort ? AddPortItem(rootItem, portName) : rootItem;
 
-    SetPortItemChecked(portItem, m_PortsConfig.IsConfigEnabled(portName));
+    if (isToShowPort)
+      SetPortItemChecked(portItem, m_PortsConfig.IsConfigEnabled(portName));
     for (const wxString &apiName : m_PortFactory.GetPortApiNames(portName)) {
       const wxTreeListItem portApiItem
         = AddPortItem(portItem, portName, apiName);