Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability of overriding AmpMinimumLevel in the .cmb file https://github.com/GrandOrgue/grandorgue/issues/782 #2089

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Jan 8, 2025

This is the first PR related to #782

This PR

  • Introduces GOEnclosure::m_DefaultAmpMinimumLevel loaded from the ODF
  • Adds Load and Save m_AmpMinimumLevel from/to .cmb
  • Adds the GetAmpMinimumLevel and SetAmpMinimumLevel methods for future use
  • Changes the data type of m_AmpMinimumLevel and m_MIDIValue to uint8_t
  • Renames GoEnclosure::Set to SetMidiValue, GoEnclosure::GetValue to GetMidiValue
  • Extracted the common part of GOEnclosure::Init and GOEnclosure::Load tp GOEnclosure::LoadFromCmb
  • Added an advanced version of GOEnclosure::SetIntMidiValue

This PR does not add any GUI for redefining AmpMinimumLevel. It will be added in a future PR after some discussion in #782

@oleg68 oleg68 requested review from rousseldenis and larspalo and removed request for rousseldenis January 8, 2025 14:27
@larspalo
Copy link
Contributor

larspalo commented Jan 9, 2025

@oleg68 I think you should focus on adding this setting only for the enclosures supplied by GO itself (on the Panels).

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 10, 2025

@oleg68 I think you should focus on adding this setting only for the enclosures supplied by GO itself (on the Panels).

This PR does not add any setting, but only adds the capability of storing the user defined value in .cmb. Do you have any reasons opposite this PR?

@oleg68
Copy link
Contributor Author

oleg68 commented Jan 19, 2025

@larspalo @rousseldenis could you approve this PR?

@oleg68 oleg68 merged commit ad1f890 into GrandOrgue:master Jan 20, 2025
1 check passed
@oleg68 oleg68 deleted the feature/enclosure-level1 branch January 20, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants