-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganised the Organ Settings dialog as tabbed https://github.com/GrandOrgue/grandorgue/issues/782 #2106
Reorganised the Organ Settings dialog as tabbed https://github.com/GrandOrgue/grandorgue/issues/782 #2106
Conversation
@oleg68 Whenever I open this (Audio/Midi->Organ settings) dialog I'm now greeted with the message dialog that I need to apply or discard the settings first. It seems that initially no level in the tree is selected and no values thus are filled. Note that this happens every single time I open the dialog. |
@larspalo There is no such issue if I build GrandOrgue on ubuntu 22, but if I build it on Ubuntu 20, the issue reappears. I'll do more researching. |
@larspalo I fixed the "apply or discard first" |
b565e51
to
42423d9
Compare
@larspalo @rousseldenis could you approve this PR? |
@oleg68 Seems like the latest builds have failed. |
@oleg68 No, sorry, I understand it now. I didn't see that it had a so similar naming to the follow up. I'll test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all my tests I've not yet found anything more that would oppose this PR.
@rousseldenis could you approve this PR? |
This is a next PR related to #782.
It introduces tabs to the Organ Settings dialog. Now only the
Pipes
tab exists.I'm going to add
Enclosures
tab later.The behavior of the Organ Settings should not change.