Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganised the Organ Settings dialog as tabbed https://github.com/GrandOrgue/grandorgue/issues/782 #2106

Merged
merged 7 commits into from
Feb 17, 2025

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Jan 25, 2025

This is a next PR related to #782.

It introduces tabs to the Organ Settings dialog. Now only the Pipes tab exists.

I'm going to add Enclosures tab later.

The behavior of the Organ Settings should not change.

@larspalo
Copy link
Contributor

@oleg68 Whenever I open this (Audio/Midi->Organ settings) dialog I'm now greeted with the message dialog that I need to apply or discard the settings first.

OrganSettingsTabbed1

It seems that initially no level in the tree is selected and no values thus are filled.

Note that this happens every single time I open the dialog.

@oleg68
Copy link
Contributor Author

oleg68 commented Feb 2, 2025

@larspalo There is no such issue if I build GrandOrgue on ubuntu 22, but if I build it on Ubuntu 20, the issue reappears. I'll do more researching.

@oleg68
Copy link
Contributor Author

oleg68 commented Feb 4, 2025

@larspalo I fixed the "apply or discard first"

@oleg68 oleg68 force-pushed the feature/organ-settings-enclosures branch from b565e51 to 42423d9 Compare February 8, 2025 18:07
@oleg68
Copy link
Contributor Author

oleg68 commented Feb 10, 2025

@larspalo @rousseldenis could you approve this PR?

@larspalo
Copy link
Contributor

@oleg68 Seems like the latest builds have failed.

@larspalo
Copy link
Contributor

@oleg68 No, sorry, I understand it now. I didn't see that it had a so similar naming to the follow up. I'll test this.

Copy link
Contributor

@larspalo larspalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all my tests I've not yet found anything more that would oppose this PR.

@oleg68
Copy link
Contributor Author

oleg68 commented Feb 15, 2025

@rousseldenis could you approve this PR?

@oleg68 oleg68 merged commit c7bf5c5 into GrandOrgue:master Feb 17, 2025
1 check passed
@oleg68 oleg68 deleted the feature/organ-settings-enclosures branch February 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants