Eliminated writting default value of midi setup to the cmb file https://github.com/GrandOrgue/grandorgue/issues/1199 #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larspalo
approved these changes
Feb 18, 2025
|
@rousseldenis Could you approve this PR? |
rousseldenis
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A next PR relating to #1199
Most of MIDI objects do not have any MIDI events assigned to them. Earlier when a user saved organ settings to a preset (*.cmb) file, the default values of MIDI object properties also were written to the file.
Now the default values are not written to .cmb, so only objects with any midi assignments appear in the saved files.
It changes nothing in loading the preset files, but it will be used for exporting MIDI settings to separate files in the future.