New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intoduced a new class GOMidiObjectContext #2131

Open

oleg68 wants to merge 1 commit into GrandOrgue:master from oleg68:feature/midi-object-context

Contributor

oleg68 commented Feb 27, 2025

This is a next PR related to #1199 and #1740.

Earlier was a flat set of midi objects that often has the same names.

This PR introduces a context hierarchy.

Each context has

name - not translated
title - translated
pointer to a parent context (if exists).

Each midi objects may belong to some context.

This feature is not used yet. I'm planning to create the following context hierarchy

manuals
- 000
  - stops
  - couplers
  - divisionals
  - banked-divisionals
- 001
setter
- generals
- banked-generals
- sequencer

No GO behavior should be changed now.


          Intermediate commit

978a98e

oleg68 requested review from larspalo and rousseldenis

February 27, 2025 19:57

Contributor Author

oleg68 commented Mar 11, 2025

@larspalo @rousseldenis could you approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet