Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes default value introspection #151

Conversation

NeedleInAJayStack
Copy link
Member

Input object and boolean default values are represented correctly in introspection.

Previous to this change, default boolean values were reported as null, and input objects were represented in JSON format ({"a": "b"} instead of { a: "b" }).

@NeedleInAJayStack NeedleInAJayStack self-assigned this Sep 25, 2024
@NeedleInAJayStack NeedleInAJayStack changed the title fix: Fixes default value introspection Fixes default value introspection Sep 25, 2024
Input object and boolean default values are represented correctly in introspection
@NeedleInAJayStack NeedleInAJayStack force-pushed the fix/instrospection-defaultValue branch from b9be0f8 to ae7983d Compare September 25, 2024 05:22
Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NeedleInAJayStack NeedleInAJayStack merged commit afbad07 into GraphQLSwift:main Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants