Skip to content

Try factoring out the dropdown boilerplate #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

kythyria
Copy link
Contributor

Related to #2587, this is a possible way to refactor the UI for dropdowns and radio buttons based on built-in enums.

There's this much indirection for a few reasons:

  1. To account for the fact that BlendMode has two different lists associated with it
  2. Using instance rather than associated methods might help with user-defined enums
  3. It'll reduce the refactoring required of built-in enums when that happens.

Probably need to move the definitions of AsU32 and DropdownableSourceStatic, that's kind of a meh name if nothing else.

@Keavon Keavon force-pushed the rfc-dropdowns-refactor branch from 1512c4a to d571abf Compare April 20, 2025 03:35
@Keavon Keavon marked this pull request as draft April 24, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants