-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Tick aggregate functions #386
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but type might be a reserved namespace in python. I would change that to script_type
…kesEnergy/sesh-dash-beta into tick_aggregate_functions
} | ||
|
||
kap = Kapacitor() | ||
t = get_template('seshdash/kapacitor_tasks/aggregate_report.tick') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using the Django template for the tick script. The user should also be able to give his/her own custom tick script. using the tick script model object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we do if the function is given a tick script instance use that as default we have the template for reports
""" | ||
This function adds a report task to kapacitor | ||
""" | ||
data = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is data hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was for testing ,Now the function accepts a report instance and pulls the data from the report instance.
Is this done? |
…e site and durationg
…kesEnergy/sesh-dash-beta into tick_aggregate_functions
are we there yet? |
Yes we are there, but there is one issue. |
Are we using the TICK model objects for the kapacitor tasks or the TICK script templates still? I couldnt see that in the code. |
We are using the templates. |
We should use the model object as this gives much more flexibility. |
Done
When you add a report, the tasks are added to kapacitor,
and when you delete report the task are deleted.
TODO:
Editing reports