Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix showing screens and add maestro tests #348

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Fix showing screens and add maestro tests #348

wants to merge 27 commits into from

Conversation

nivekgtc
Copy link

@nivekgtc nivekgtc commented Feb 18, 2025 •
edited by pierrelstan
Loading

Description

Fix blank screens and add maestro tests

Fixes: # (issue number)
or
Resolves: # (issue number)

Changes Made

  • Changes in apps folder (specify the app and briefly describe the changes):

    • Web
    • Native

  • Changes in packages folder (specify the package and briefly describe the changes):

    • Core

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • [] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update (changes)

Screenshots

Before After
"screenshot before" "screenshot after"

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests
  • Maestro mobile tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Comments

(Optional) Add any addition
Fixing iOS screens.pdf
al comments or notes for reviewers here.

dagmawig and others added 7 commits January 25, 2025 16:50
@nivekgtc nivekgtc requested a review from a team as a code owner February 18, 2025 01:32
@nivekgtc nivekgtc force-pushed the fix-showing-screens branch from a31eae6 to 5505024 Compare February 18, 2025 02:11
@nivekgtc nivekgtc changed the title Fix showing screens Fix showing screens and add maestro tests Feb 18, 2025
pierrelstan
pierrelstan requested changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@pierrelstan pierrelstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nivekgtc , thank you for your work!

I noticed that your PR is 3 commits ahead and 8 commits behind Greenstand/treetracker-wallet-app:main. Could you please update your PR branch with the latest changes from the main branch (Greenstand/treetracker-wallet-app:main)? This will help ensure everything is up to date and prevent any merge conflicts.

Please feel free to reach out if you need any help!

pierrelstan and others added 16 commits February 19, 2025 18:59
@pierrelstan
chore: add missing workspace scripts in package.json
112c816
@pierrelstan
Merge pull request Greenstand#349 from Greenstand/chore/add-missing-s…
b7adea3 
…cripts

chore: add missing workspace scripts in package.json
@pierrelstan
feat: add custom button
b10fb6d
@pierrelstan
refactor: rename function, add slot
687bdeb
@pierrelstan
fix: add onboarding
3c63f8c
@pierrelstan
fix: rename function, add verifyAppLayoutStatus
e37268d
@pierrelstan
Merge pull request Greenstand#351 from Greenstand/fix/onboarding-screen
df766df
@pierrelstan
feat: add login screen textinput button title (Greenstand#354)
b402f81
@nivekgtc
feat: merge with main solving conflicts
2ab1e97
@pierrelstan
chore: linting format ci (Greenstand#367)
3f6218d 
* chore: add support for .md extension

* chore: add .prettierignore

* chore: add lint-format.yml for CI pipeline

* style: apply Prettier formatting to code
@pierrelstan
chore: add Prettier check to CI workflow (Greenstand#369)
cfa0a69
@pierrelstan
chore: update titles and fix comment in PR template (Greenstand#372)
4652d43
@dadiorchen
Merge pull request Greenstand#327 from dagmawig/queue-sub
0d3b945 
fix: update subscribe function with event emitter
@nivekgtc
test(e2e): fix onboarding tests
e3492d7
@nivekgtc
build(e2e): add necessary deps to ensure e2e tests
0e27441
@nivekgtc
Merge branch 'main' into fix-showing-screens
ee2ad8e
@nivekgtc
Copy link
Author

M

Hi @nivekgtc , thank you for your work!

I noticed that your PR is 3 commits ahead and 8 commits behind Greenstand/treetracker-wallet-app:main. Could you please update your PR branch with the latest changes from the main branch (Greenstand/treetracker-wallet-app:main)? This will help ensure everything is up to date and prevent any merge conflicts.

Please feel free to reach out if you need any help!

I updated that.
And fixed the tests related
Screenshot 2025-02-24 at 21 49 39
Screenshot 2025-02-24 at 21 50 32

@nivekgtc nivekgtc requested a review from pierrelstan February 25, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrelstan pierrelstan Awaiting requested review from pierrelstan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nivekgtc @pierrelstan @dagmawig @kshitij79 @dadiorchen