-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing flags for materials #2024
Merged
screret
merged 6 commits into
GregTechCEu:1.20.1
from
JuiceyBeans:diamond-screwdriver-fix
Oct 1, 2024
Merged
Add missing flags for materials #2024
screret
merged 6 commits into
GregTechCEu:1.20.1
from
JuiceyBeans:diamond-screwdriver-fix
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
approved these changes
Sep 26, 2024
2 tasks
Before merging, do check whether the debug lines should be left in. It doesn't find anymore missing flags and could be useful for future materials |
screret
requested changes
Sep 29, 2024
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
screret
approved these changes
Sep 30, 2024
krossgg
pushed a commit
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ToolRecipeHandler#softMaterials
Implementation
softMaterials
array has been moved fromToolRecipeHandler#addWoodRecipes
Outcome
A lot of tool parts are now craftable
Fixes #2021