Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing flags for materials #2024

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

JuiceyBeans
Copy link
Contributor

@JuiceyBeans JuiceyBeans commented Sep 24, 2024

What

  • Adds missing flags to a ton of materials so that their tool recipes generate
  • Adds debug lines to catch missing flags for materials
  • Adds styrene butadiene and silicone rubber to ToolRecipeHandler#softMaterials

Implementation

softMaterials array has been moved from ToolRecipeHandler#addWoodRecipes

Outcome

A lot of tool parts are now craftable
Fixes #2021

@JuiceyBeans JuiceyBeans marked this pull request as ready for review September 24, 2024 23:39
@JuiceyBeans JuiceyBeans requested a review from a team as a code owner September 24, 2024 23:39
@JuiceyBeans JuiceyBeans deleted the diamond-screwdriver-fix branch September 26, 2024 11:05
@JuiceyBeans JuiceyBeans restored the diamond-screwdriver-fix branch September 26, 2024 11:07
@JuiceyBeans JuiceyBeans reopened this Sep 26, 2024
@JuiceyBeans
Copy link
Contributor Author

JuiceyBeans commented Sep 29, 2024

Before merging, do check whether the debug lines should be left in. It doesn't find anymore missing flags and could be useful for future materials

@screret screret added the type: bugfix general bug fixes label Sep 29, 2024
@JuiceyBeans JuiceyBeans requested a review from screret September 29, 2024 14:13
@screret screret merged commit afd65ab into GregTechCEu:1.20.1 Oct 1, 2024
3 checks passed
krossgg pushed a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing recipe for Diamond Screwdriver (LV)
2 participants