Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 small helpers for Fluid Tanks #2046

Closed
wants to merge 3 commits into from

Conversation

Rundas01
Copy link
Contributor

What

Fluid Tanks don't have methods to return how much space they have. I needed that for some primitive multiblocks and thought that other people might need the same at some point. If deemed unnecessary, you can yeet this PR.

@Rundas01 Rundas01 requested a review from a team as a code owner September 27, 2024 21:37
always forget the fecking spotless
@Pumpkin7266
Copy link
Contributor

btw can you check dev-talks on discord?

Copy link
Member

@screret screret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a helper method instead tyvm

@screret
Copy link
Member

screret commented Sep 28, 2024

in like, GTTransferUtils

@krossgg
Copy link
Contributor

krossgg commented Sep 28, 2024

Why is this necessary? You can use the fill method with the simulate flag in order to test if a tank can take the fluid you're trying to put in.

@Rundas01
Copy link
Contributor Author

Why is this necessary? You can use the fill method with the simulate flag in order to test if a tank can take the fluid you're trying to put in.

didn't know you can do that. like I said, if unnecessary, yeet the PR

@Rundas01 Rundas01 closed this Sep 28, 2024
@Rundas01 Rundas01 deleted the fluidtank-helpers branch September 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants