Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam and bedrock miner multi changes #2106

Closed
wants to merge 3 commits into from

Conversation

Deepacat
Copy link
Contributor

@Deepacat Deepacat commented Oct 8, 2024

What

Changes to bedrock miners as well as steam multi block registering, I made these changes for my modpack to allow custom bedrock miners as well as steam multiblocks for other people to use.

Implementation Details

For bedrock miners you can optionally give extra arguments to customize depletion chance as well as mined multiplier, this does not touch the base registered multiblocks and is solely for creating new ones for pack developers
The default bedrock miners are also now registered more similarly to the regular ore miners, which is more clean.

Steam multiblocks can now be registered with their parallel value as an argument, this allows creating custom steam multis with 1 parallel to create a regular steam multiblock.

Outcome

Modpack developers can now create bedrock miners with custom arguments easily, as well as creating their own steam multiblocks easily

Additional Information

Cyb maybe doing further bedrock miner rewrites in future

Potential Compatibility Issues

Will likely cause addons creating custom steam multiblocks to update to the new parallel arguments

@Deepacat Deepacat requested a review from a team as a code owner October 8, 2024 03:20
@krossgg krossgg added the type: bugfix general bug fixes label Oct 8, 2024
@Deepacat
Copy link
Contributor Author

Deepacat commented Oct 8, 2024

ok ill just do the steam multi changes

@Deepacat Deepacat closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants