Steam and bedrock miner multi changes #2106
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes to bedrock miners as well as steam multi block registering, I made these changes for my modpack to allow custom bedrock miners as well as steam multiblocks for other people to use.
Implementation Details
For bedrock miners you can optionally give extra arguments to customize depletion chance as well as mined multiplier, this does not touch the base registered multiblocks and is solely for creating new ones for pack developers
The default bedrock miners are also now registered more similarly to the regular ore miners, which is more clean.
Steam multiblocks can now be registered with their parallel value as an argument, this allows creating custom steam multis with 1 parallel to create a regular steam multiblock.
Outcome
Modpack developers can now create bedrock miners with custom arguments easily, as well as creating their own steam multiblocks easily
Additional Information
Cyb maybe doing further bedrock miner rewrites in future
Potential Compatibility Issues
Will likely cause addons creating custom steam multiblocks to update to the new parallel arguments