Allow Steam Multiblocks to have variable parallel amounts #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krossgg
requested changes
Oct 9, 2024
...va/com/gregtechceu/gtceu/common/machine/multiblock/steam/SteamParallelMultiblockMachine.java
Outdated
Show resolved
Hide resolved
...va/com/gregtechceu/gtceu/common/machine/multiblock/steam/SteamParallelMultiblockMachine.java
Outdated
Show resolved
Hide resolved
...va/com/gregtechceu/gtceu/common/machine/multiblock/steam/SteamParallelMultiblockMachine.java
Show resolved
Hide resolved
|
Somethings wrong it is paralleling incorrectly, I am doing more testing |
krossgg
approved these changes
Oct 10, 2024
krossgg
changed the title
krossgg
pushed a commit
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changed steam multiblock parallels to not be hardcoded to 8
Implementation Details
Changes parallel value to be passed through the builder of SteamParallelMultiblockMachine rather than hardcoded to 8
Adds a config option for default parallel value of steam multis
Outcome
Players can now change the amount steam multis parallel in config
Modpack developers can now create custom steam multiblocks easily with however many parallels or none at all
Potential Compatibility Issues
Addons that create custom steam multiblocks will likely need to be edited to use the new parallel argument (eg. Steam additions)