Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor configs for vanilla recipes #2197

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Refactor configs for vanilla recipes #2197

merged 3 commits into from
Oct 16, 2024

Conversation

JuiceyBeans
Copy link
Contributor

@JuiceyBeans JuiceyBeans commented Oct 16, 2024 •
edited
Loading

What

  • Move a bunch of recipes around
  • Buff chain recipe using steel
  • Add javadoc for some recipe removals/additions configs

Outcome

Resolves #2194

@JuiceyBeans JuiceyBeans requested a review from a team as a code owner October 16, 2024 20:22
Ghostipedia
Ghostipedia requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Ghostipedia Ghostipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes are fine, just fix up the description lang 🪟

src/main/java/com/gregtechceu/gtceu/data/recipe/configurable/RecipeRemoval.java Outdated Show resolved Hide resolved
@Ghostipedia Ghostipedia added the type: refactor Suggestion to refactor a section of code label Oct 16, 2024
@Ghostipedia Ghostipedia merged commit af38d76 into GregTechCEu:1.20.1 Oct 16, 2024
2 checks passed
krossgg pushed a commit that referenced this pull request Oct 30, 2024
@JuiceyBeans @krossgg
Refactor configs for vanilla recipes (#2197)
53ca6d4
screret pushed a commit that referenced this pull request Dec 5, 2024
@JuiceyBeans @screret
Refactor configs for vanilla recipes (#2197)
15448b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghostipedia Ghostipedia Ghostipedia approved these changes

Assignees
No one assigned
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Vanilla Recipes not Pruned when using Hard GT Recipes.
2 participants
@JuiceyBeans @Ghostipedia