Internal Machine and Material Class Refactor #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into yo/machine-refactor # Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/GTFluids.java # src/main/java/com/gregtechceu/gtceu/common/data/GTItems.java # src/main/java/com/gregtechceu/gtceu/common/data/GTMachines.java # src/main/java/com/gregtechceu/gtceu/common/data/machines/GTCreateMachines.java # src/main/java/com/gregtechceu/gtceu/integration/emi/GTEMIPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/jei/GTJEIPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/KineticMachineBuilder.java # src/main/java/com/gregtechceu/gtceu/integration/rei/GTREIPlugin.java
… into yo/machine-refactor # Conflicts: # src/main/java/com/gregtechceu/gtceu/api/data/chemical/ChemicalHelper.java # src/main/java/com/gregtechceu/gtceu/common/data/GTMachines.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/GeneratorBuilder.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/MachineFunctionPresets.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/SimpleMachineBuilder.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/GTMachines.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GregTechKubeJSPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/KJSTieredMachineBuilder.java
Spicierspace153
approved these changes
Dec 20, 2024
omergunr100
pushed a commit
to omergunr100/GregTech-Modern
that referenced
this pull request
Dec 25, 2024
Co-authored-by: Stanley Goodwin <[email protected]> Co-authored-by: screret <[email protected]>
screret
added a commit
that referenced
this pull request
Dec 28, 2024
Co-authored-by: Stanley Goodwin <[email protected]> Co-authored-by: screret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactors around various parts of
GTMachines,GTItemsandGTBlocksinto more classes for easier management, notablyGTMultiMachines,GTMachineUtils,GTMaterialBlocksandGTMaterialItemsFixes #2528
Implementation Details
Lots of refactoring
Outcome
Hopefully cleaner navigation for machine registration.
Potential Compatibility Issues
will break all addons, they just need to update paths.