Refactor LDLib calls #2609
Merged
Refactor LDLib calls #2609
+453
−385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was after a couple hours of fighting with the vertex methods
2 tasks
If your ball is too big for your mouth it's not yours.
tomprince
reviewed
Dec 21, 2024
src/main/java/com/gregtechceu/gtceu/api/machine/IMachineBlockEntity.java
Outdated
Show resolved
Hide resolved
krossgg
changed the title
screret
reviewed
Dec 27, 2024
…inge # Conflicts: # src/main/java/com/gregtechceu/gtceu/integration/emi/GTEMIPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/emi/recipe/GTRecipeEMICategory.java # src/main/java/com/gregtechceu/gtceu/integration/jei/GTJEIPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/jei/recipe/GTRecipeJEICategory.java # src/main/java/com/gregtechceu/gtceu/integration/rei/GTREIPlugin.java # src/main/java/com/gregtechceu/gtceu/integration/rei/recipe/GTRecipeREICategory.java
krossgg
requested changes
Dec 28, 2024
src/main/java/com/gregtechceu/gtceu/integration/jei/GTJEIPlugin.java
Outdated
Show resolved
Hide resolved
krossgg
requested changes
Dec 30, 2024
src/main/java/com/gregtechceu/gtceu/core/mixins/WorldLoaderMixin.java
Outdated
Show resolved
Hide resolved
krossgg
added
type: refactor
replace xei loaded checks in jei loaded check with just the isModLoaded check. moved frozen registry shenanigans to GTRegistries and an event listener to replace the mixin (seems to be working fine).
krossgg
requested changes
Dec 30, 2024
src/main/java/com/gregtechceu/gtceu/forge/ForgeCommonEventListener.java
Outdated
Show resolved
Hide resolved
krossgg
approved these changes
Dec 30, 2024
screret
requested changes
Dec 30, 2024
src/main/java/com/gregtechceu/gtceu/api/registry/GTRegistries.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/com/gregtechceu/gtceu/client/ClientProxy.java # src/main/java/com/gregtechceu/gtceu/data/recipe/CraftingComponent.java # src/main/java/com/gregtechceu/gtceu/integration/map/GroupingMapRenderer.java # src/main/java/com/gregtechceu/gtceu/integration/map/WaypointManager.java # src/main/java/com/gregtechceu/gtceu/integration/map/xaeros/XaerosMapPlugin.java
screret
approved these changes
Jan 4, 2025
YoungOnionMC
approved these changes
Jan 4, 2025
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored some rendering code and replaced the ldlib mod load check with the forge method.
Unldlibning wherever possible without losing my sanity.
Implementation Details
Refactored some conditions in rendering code to use the appropriate methods.
Refactored mod load checks to use native forge methods instead of ldlib method.
Outcome
Reduced LDLib Dependency