Add FTB Chunks ore prospector compatibility #2642
Conversation
src/main/java/com/gregtechceu/gtceu/integration/map/ftbchunks/veins/ore/OreVeinIcon.java
Outdated
Show resolved
Hide resolved
|
Really looking forward to this! Take my comments with a grain of salt, I'm not part of the devteam - I just like testing things. |
|
your right click menu and large map mixin look good, I'll cherry pick them over to my branch, though the mini map at least from what I understand is a much more limited version of the large map, and mouse/key click events don't trigger on it, so I don't think that the large map type check is necessary (unless you managed to trigger them on the mini map that is) |
|
oh never mind you just used it to cast |
apparently mixin into the static block of an interface is a big no no
|
I think it's done |
src/main/java/com/gregtechceu/gtceu/data/lang/IntegrationLang.java
Outdated
Show resolved
Hide resolved
|
found a bug with the fluid widget waypoint code, will debug it tomorrow, don't merge this yet |
using widgets for large map because they look a lot better and scale.
|
Fixed the bug, the fluid vein overlay for the minimap is kind of weird, I could just remove it entirely, would appreciate more opinions |
|
I think it should render the fluids on the minimap as well. |
|
I think I should add a way to switch specific map mod compats on/off through the config. |
|
Dejankified the minimap fluid vein overlay... with one tiny downside, if the ftb team decide to do a refactor of how they render waypoints it'll (in some likelyhood) cause ftb chunks not to load. |
storing some values from locals instead of calculating twice.
|
|
||
| @Configurable | ||
| @Configurable.Comment({ "Xaerox's map integration enabled" }) | ||
| public boolean xaeroxMapIntegration = true; |
|
|
||
| @Configurable | ||
| @Configurable.Comment({ "FTB Chunks integration enabled" }) | ||
| public boolean chunksIntegration = false; |
What
Show ore veins and bedrock fluids in the FTB Chunks map.
Implementation Details
Ore veins are using the ftb api, for the fluid veins needed to resort to mixins.
Outcome
Resolves #2587
Additional Information
Fixes long standing bug where fluid veins were serialized incorrectly, yield and percentage left were reversed in serialization.