add material armors #2656
Open
add material armors #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghostipedia
requested changes
Dec 28, 2024
There was a problem hiding this comment.
By default, make this only create Bronze & Steel Armor.
There's alr a kube builder pack devs can use to enable more materials but for the sake of the base-mod balancing only Bronze and Steel should exist.
Anything Higher may clash or not be ideal to have when we write our new armor system.
…packs' textures if one exists in the dynamic packs in any namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add material armors. The armor property is currently added to most materials with tool properties.
Implementation Details
small mixin to load armor color data on the armor model.
mostly vanilla/forge logic otherwise.
Outcome
colorful armors yippee!
Additional Information