Add multiblock constructors to KJS + lang #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new class
MachineConstructorswhich is exposed to KJS as an easy way to use constructors for non-default machine types without having to manually load the class. This class is readily expandable.Also, lang generation has been added to
MultiblockMachineBuilderso that Kubers can make multiblock lang in-place.Outcome
This incidentally fixes a funny issue where loading the
LargeCombustionEngineMachineclass in a KJS server script will crash the game, as it tries to initialize the static FluidStack before the materials have valid fluids.