fix rotary hearth furnace parallel not taking energy discount into account #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n calculating max parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n calculating max parallel
What
The rotary hearth furnace does not take into account the energy discount from the coils when calculating the max parallel, causing the rotary hearth furnace to have a lower parallel count than expected in some cases.
Implementation Details
Recipe modifiers ebfDiscount and ebfOverclockOnly were created, and ebfOverclock changed to use these. The recipe modifiers for rotary hearth furnace was changed to ebfDiscount, then parallel hatch, then ebfOverclockOnly
Outcome
The rotary hearth furnace appears to have the correct behaviour now, further testing may be necessary