feat: postgres_fdw demo #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (3)
- postgres-fdw/.gitignore: Language not supported
- postgres-fdw/docker-entrypoint-initdb.d/init.sh: Language not supported
- postgres-fdw/greptime.env.sample: Language not supported
Comments suppressed due to low confidence (1)
postgres-fdw/vector.toml:12
- [nitpick] The sink name 'logs_out2' is ambiguous and does not clearly describe its purpose. Consider renaming it to something more descriptive, such as 'greptimedb_sink'.
[sinks.logs_out2]
waynexia
approved these changes
Dec 13, 2024
Comment on lines
+38
to
+40
| Next, use `psql` to access vanilla postgres using `psql -h 127.0.0.1 -p 5432 -U | ||
| postgres`. You can check foreign servers and tables, query data from the remote | ||
| GreptimeDB. |
There was a problem hiding this comment.
Do we need to explain briefly how PostgreSQL recognizes GreptimeDB? Maybe a link to init.sh
There was a problem hiding this comment.
It's explained in "How it works" section below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demo shows how GreptimeDB works with postgres_fdw to provide foreign data access for Postgres. It follows our best practice for demo that: 1. works with both local and cloud GreptimeDB, 2. (almost) zero dependency required to setup.