Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce the region state #112

Closed
wants to merge 1 commit into from

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Introduce the region state

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu force-pushed the feat/region_state branch from 5a0637f to 176bffb Compare October 23, 2023 05:47
@@ -60,6 +66,8 @@ message RegionStat {
int64 approximate_rows = 5;
// engine name
string engine = 6;
// Indicate region's state.
RegionState state = 7;
Copy link
Contributor

@fengjiachun fengjiachun Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:

  1. Do we need the Unknown? Is it enough to use None to represent it?
  2. I think Readonly/Writeable is a role rather than a state, for example in the future, we will also have a datanode that is specifically responsible for compaction, at which time we can add a Compactor role.

@WenyXu WenyXu closed this Oct 23, 2023
@WenyXu WenyXu deleted the feat/region_state branch October 23, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants