Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass tracing context in proto #120

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: pass tracing context in proto #120

merged 2 commits into from
Nov 15, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Pass tracing_context follow the w3c standard in protobuf (replace original trace_id & span_id), enable distributed tracing in greptimedb

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

waynexia
waynexia approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit 2542930 into GreptimeTeam:main Nov 15, 2023
6 checks passed
@Taylor-lagrange Taylor-lagrange mentioned this pull request Nov 16, 2023
Merged
2 tasks
@Taylor-lagrange Taylor-lagrange deleted the feat-tracing branch December 26, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taylor-lagrange @MichaelScofield @waynexia