Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message decimal128 #131

Closed
wants to merge 2 commits into from
Closed

fix: message decimal128 #131

wants to merge 2 commits into from

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Dec 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

use uint64 to keep decimal128 low-64 bit

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@QuenKar QuenKar changed the title Fix/decimal struct fix: message decimal128 Dec 18, 2023
@QuenKar QuenKar closed this Dec 18, 2023
@QuenKar
Copy link
Contributor Author

QuenKar commented Dec 18, 2023

After discussion, we decide to not modify proto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@QuenKar