Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tonic to 0.11 #140

Closed
wants to merge 1 commit into from
Closed

feat: update tonic to 0.11 #140

wants to merge 1 commit into from

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Mar 21, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Use tonic 0.11

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87
Copy link
Member Author

sunng87 commented Mar 21, 2024

We will need to wait arrow 51 release and updated for greptimedb to merge this.

@sunng87 sunng87 marked this pull request as draft March 21, 2024 23:02
@sunng87
Copy link
Member Author

sunng87 commented Mar 29, 2024

Related GreptimeTeam/greptimedb#3554

@sunng87 sunng87 marked this pull request as ready for review March 29, 2024 23:08
@tisonkun
Copy link
Contributor

tisonkun commented Apr 3, 2024

We will need to wait arrow 51 release and updated for greptimedb to merge this.

What is the concrete issue/blocker here? Why should we wait for arrow upgrade to upgrade tonic?

@sunng87
Copy link
Member Author

sunng87 commented Apr 3, 2024

Just for a clean upgrade because arrow-flight has a dependency to tonic.

@tisonkun
Copy link
Contributor

Resolved by #148.

@tisonkun tisonkun closed this Apr 27, 2024
@tisonkun tisonkun deleted the feature/tonic-011 branch April 27, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants