Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add source_tables and source_table_ids #151

Merged
merged 5 commits into from
Apr 25, 2024
Merged

feat: add source_tables and source_table_ids #151

merged 5 commits into from
Apr 25, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 25, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add source_tables to CreateFlowTaskExpr
  2. Add source_table_ids to FlowCreateRequest
  3. Rename CreateTaskExpr to CreateFlowTaskExpr
  4. Rename RemoveTaskExpr to RemoveFlowTaskExpr
  5. Introduce ScheamScopedTableName(struct { schema_name, table_name })
  6. Rename FlowCreateRequest to CreateRequest.
  7. Rename FlowRemoveRequest to RemoveRequest.
  8. rename output_ to sink_.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fengjiachun
fengjiachun approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 93ebc1b into GreptimeTeam:main Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discord9 discord9 discord9 approved these changes

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WenyXu @fengjiachun @waynexia @discord9