Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add options for remote compaction #177

Closed

Conversation

zyy17
Copy link
Contributor

@zyy17 zyy17 commented Jun 9, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add the Remote{} for remote compaction.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@zyy17
Copy link
Contributor Author

zyy17 commented Jun 17, 2024

It's a draft PR for adding Remote{} in CompactRequest. We can discuss whether it's a reasonable modification before the formal review.

@zyy17 zyy17 force-pushed the refactor/add-remote-compaction-options branch from 6b12c79 to 1803bf8 Compare June 19, 2024 03:14
@zyy17 zyy17 closed this Jun 19, 2024
@zyy17
Copy link
Contributor Author

zyy17 commented Jun 19, 2024

After some thought, adding remote_compaction to region_options will be convenient. We can add a similar option in proto in the future.

@zyy17 zyy17 deleted the refactor/add-remote-compaction-options branch July 21, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant