Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change AlterExpr api #185

Closed
wants to merge 13 commits into from
Closed

Conversation

irenjj
Copy link

@irenjj irenjj commented Jul 29, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

related: GreptimeTeam/greptimedb#4395

What's changed and what's your intention?

To support syntax of ALTER TABLE monitor SET COLUMN load_15 fulltext WITH (...), we should add AddFulltext enum member.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 requested a review from fengjiachun July 29, 2024 17:56
@fengjiachun
Copy link
Contributor

It can be merged once the upcoming code PR is ready. cc @irenjj

By the way, the CI failed.

proto/greptime/v1/ddl.proto Outdated Show resolved Hide resolved
@irenjj irenjj force-pushed the add_fulltext branch 4 times, most recently from 1f12e8b to 6df0c7b Compare October 8, 2024 14:46
proto/greptime/v1/ddl.proto Outdated Show resolved Hide resolved
@CookiePieWw CookiePieWw mentioned this pull request Nov 7, 2024
2 tasks
@WenyXu
Copy link
Member

WenyXu commented Nov 12, 2024

Thanks, @irenjj ❤️! The patch has been merged in #196

@WenyXu WenyXu closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants