Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flow state size #193

Merged
merged 5 commits into from
Oct 29, 2024
Merged

feat: flow state size #193

merged 5 commits into from
Oct 29, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Oct 25, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add a field to report all flow task's internal state's memory size in heartbeat

Please explain IN DETAIL what the changes are in this PR and why they are needed:
The rest of code to update this report lies in https://github.com/discord9/greptimedb/tree/flow_state_size
and make this size report when creating heartbeat msg

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

@discord9 discord9 requested review from WenyXu and waynexia October 28, 2024 03:28
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/greptime/v1/meta/heartbeat.proto Outdated Show resolved Hide resolved
@discord9 discord9 merged commit fc45ac4 into main Oct 29, 2024
6 checks passed
@discord9 discord9 deleted the flow_stat_size branch October 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants