Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flow replace option #198

Merged
merged 6 commits into from
Nov 14, 2024
Merged

feat: flow replace option #198

merged 6 commits into from
Nov 14, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add a is_create_or_replace option which set to true when create flow with CREATE OR REPLACE FLOW....

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

waynexia
waynexia approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

@discord9 discord9 merged commit e1070ad into main Nov 14, 2024
6 checks passed
@discord9 discord9 deleted the flow_replace branch November 14, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@discord9 @waynexia @WenyXu