-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add opentelemetry usage example #47
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 7 7
Lines 466 466
=======================================
Hits 346 346
Misses 97 97
Partials 23 23 ☔ View full report in Codecov by Sentry. |
by the way, is there any concept like feature gate or optional dependency in go? I would suggest to make otel deps optional so we keep the core sdk compact. |
Yes, a switch option has been added to the configuration. The default value is false, which means it is closed. If the user needs to turn it on, it can be set to true. Here users need to install tracing and metrics backends such as jaeger and prometheus.
Also, the deps go.mod is set here so as not to affect the project's main go.mod and not to pollute the contents of the main go.mod. |
Modify are complete and ready for review @zyy17 |
What's changed and what's your intention?
When after #39 merge, we can provide some example to user.
Checklist
Refer to a related PR or issue link (optional)