Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: format pom and code #39

Merged
merged 20 commits into from
Mar 19, 2024
Merged

build: format pom and code #39

merged 20 commits into from
Mar 19, 2024

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Mar 19, 2024

Before starting hacking in this project, employing common code formatting rules:

  • License header checker makes easy.
  • Spotless for auto formatting.
  • Sortpom can fail on verify; properties group helps.
  • Remove redundant properties.
  • Drop @author tag to avoid "this is not my file" feeling.

tisonkun added 12 commits March 19, 2024 08:58
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun requested a review from fengjiachun March 19, 2024 01:31
tisonkun and others added 3 commits March 19, 2024 17:48
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun merged commit 4fa729a into main Mar 19, 2024
4 checks passed
@tisonkun tisonkun deleted the fmt branch March 19, 2024 09:52
@tisonkun
Copy link
Contributor Author

Some follow-ups -

  • Add docs about how to run the formatter (spotless, hawkeye)
  • Try to integrate formatting into compile phase or the default lifecycle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants