chore: rename exist to exists

GreptimeTeam · Nov 27, 2023 · 2f8ad55 · 2f8ad55
1 parent a784d56
commit 2f8ad55
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/common/meta/src/instruction.rs b/src/common/meta/src/instruction.rs
@@ -51,17 +51,20 @@ impl Display for RegionIdent {
 /// The result of downgrade leader region.
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)]
 pub struct DowngradeRegionReply {
+    /// Returns the `last_entry_id` if available.
     pub last_entry_id: Option<u64>,
-    pub exist: bool,
+    /// Indicates whether the region exists.
+    pub exists: bool,
+    /// Return error if any during the operation.
     pub error: Option<String>,
 }
 
 impl Display for DowngradeRegionReply {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         write!(
             f,
-            "(last_entry_id={:?}, exist={}, error={:?})",
-            self.last_entry_id, self.exist, self.error
+            "(last_entry_id={:?}, exists={}, error={:?})",
+            self.last_entry_id, self.exists, self.error
         )
     }
 }

diff --git a/src/meta-srv/src/procedure/region_migration/downgrade_leader_region.rs b/src/meta-srv/src/procedure/region_migration/downgrade_leader_region.rs
@@ -122,7 +122,7 @@ impl DowngradeLeaderRegion {
                 let reply = HeartbeatMailbox::json_reply(&msg)?;
                 let InstructionReply::DowngradeRegion(DowngradeRegionReply {
                     last_entry_id,
-                    exist,
+                    exists,
                     error,
                 }) = reply
                 else {
@@ -143,7 +143,7 @@ impl DowngradeLeaderRegion {
                     .fail();
                 }
 
-                if !exist {
+                if !exists {
                     warn!(
                         "Trying to downgrade the region {} on Datanode {}, but region doesn't exist!",
                         region_id, leader
@@ -239,7 +239,7 @@ mod tests {
             payload: Some(Payload::Json(
                 serde_json::to_string(&InstructionReply::DowngradeRegion(DowngradeRegionReply {
                     last_entry_id,
-                    exist,
+                    exists: exist,
                     error,
                 }))
                 .unwrap(),