fix: support alter table ~ add ~ custom_type (#5165)

GreptimeTeam · Dec 15, 2024 · 358d5e1 · 358d5e1
1 parent 579059d
commit 358d5e1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 7 deletions.
diff --git a/src/sql/src/statements/transform/type_alias.rs b/src/sql/src/statements/transform/type_alias.rs
@@ -57,6 +57,10 @@ impl TransformRule for TypeAliasTransformRule {
                     alter_table.alter_operation_mut()
                 {
                     replace_type_alias(target_type)
+                } else if let AlterTableOperation::AddColumn { column_def, .. } =
+                    alter_table.alter_operation_mut()
+                {
+                    replace_type_alias(&mut column_def.data_type);
                 }
             }
             _ => {}

diff --git a/tests/cases/standalone/common/alter/alter_table.result b/tests/cases/standalone/common/alter/alter_table.result
@@ -140,10 +140,17 @@ ADD
 
 Affected Rows: 0
 
+ALTER TABLE 
+    t2 
+ADD 
+    COLUMN at4 UINT16;
+
+Affected Rows: 0
+
 INSERT INTO
     t2
 VALUES
-    ("loc_1", "loc_2", "loc_3", 'job1', 0, 1);
+    ("loc_1", "loc_2", "loc_3", 2, 'job1', 0, 1);
 
 Affected Rows: 1
 
@@ -152,11 +159,11 @@ SELECT
 FROM
     t2;
 
-+-------+-------+-------+------+---------------------+-----+
-| at    | at2   | at3   | job  | ts                  | val |
-+-------+-------+-------+------+---------------------+-----+
-| loc_1 | loc_2 | loc_3 | job1 | 1970-01-01T00:00:00 | 1.0 |
-+-------+-------+-------+------+---------------------+-----+
++-------+-------+-------+-----+------+---------------------+-----+
+| at    | at2   | at3   | at4 | job  | ts                  | val |
++-------+-------+-------+-----+------+---------------------+-----+
+| loc_1 | loc_2 | loc_3 | 2   | job1 | 1970-01-01T00:00:00 | 1.0 |
++-------+-------+-------+-----+------+---------------------+-----+
 
 DROP TABLE t1;
 

diff --git a/tests/cases/standalone/common/alter/alter_table.sql b/tests/cases/standalone/common/alter/alter_table.sql
@@ -67,10 +67,15 @@ ALTER TABLE
 ADD
     COLUMN at2 STRING;
 
+ALTER TABLE 
+    t2 
+ADD 
+    COLUMN at4 UINT16;
+
 INSERT INTO
     t2
 VALUES
-    ("loc_1", "loc_2", "loc_3", 'job1', 0, 1);
+    ("loc_1", "loc_2", "loc_3", 2, 'job1', 0, 1);
 
 SELECT
     *