fix: 10000 years --> forever

GreptimeTeam · Dec 4, 2024 · 9d8b08d · 9d8b08d
1 parent 449c1c0
commit 9d8b08d
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/src/common/base/src/ttl.rs b/src/common/base/src/ttl.rs
@@ -21,7 +21,7 @@ use serde::{Deserialize, Serialize};
 /// Time To Live
 #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Default)]
 pub enum TimeToLive {
-    /// immediately throw away on insert
+    /// Immediately throw away on insert
     Immediate,
     /// Duration to keep the data, this duration should be non-zero
     Duration(Duration),
@@ -56,6 +56,7 @@ impl<'de> Deserialize<'de> for TimeToLive {
                 formatter.write_str("a string of time, 'immediate', 'forever' or null")
             }
 
+            /// Correctly deserialize null in json
             fn visit_unit<E>(self) -> Result<Self::Value, E> {
                 Ok(TimeToLive::Forever)
             }
@@ -84,7 +85,9 @@ impl Display for TimeToLive {
 }
 
 impl TimeToLive {
-    /// Parse a string into TimeToLive
+    /// Parse a string that is either `immediate`, `forever`, or a duration to `TimeToLive`
+    ///
+    /// note that a empty string is treat as `forever` too
     pub fn from_humantime_or_str(s: &str) -> Result<Self, String> {
         match s {
             "immediate" => Ok(TimeToLive::Immediate),

diff --git a/src/metric-engine/src/engine/create.rs b/src/metric-engine/src/engine/create.rs
@@ -540,7 +540,7 @@ pub(crate) fn region_options_for_metadata_region(
     mut original: HashMap<String, String>,
 ) -> HashMap<String, String> {
     original.remove(APPEND_MODE_KEY);
-    original.insert(TTL_KEY.to_string(), "10000 years".to_string());
+    original.insert(TTL_KEY.to_string(), "forever".to_string());
     original
 }
 
@@ -731,7 +731,7 @@ mod test {
         );
         assert_eq!(
             metadata_region_request.options.get("ttl").unwrap(),
-            "10000 years"
+            "forever"
         );
     }
 }
diff --git a/tests/cases/standalone/common/alter/alter_database.result b/tests/cases/standalone/common/alter/alter_database.result
@@ -62,6 +62,9 @@ SHOW CREATE DATABASE alter_database;
 | Database       | Create Database                              |
 +----------------+----------------------------------------------+
 | alter_database | CREATE DATABASE IF NOT EXISTS alter_database |
+|                | WITH(                                        |
+|                |   ttl = 'forever'                            |
+|                | )                                            |
 +----------------+----------------------------------------------+
 
 ALTER DATABASE alter_database SET 'ttl'='😁';

diff --git a/tests/cases/standalone/common/alter/alter_table_options.result b/tests/cases/standalone/common/alter/alter_table_options.result
@@ -103,7 +103,9 @@ SHOW CREATE TABLE ato;
 |       | )                                  |
 |       |                                    |
 |       | ENGINE=mito                        |
-|       |                                    |
+|       | WITH(                              |
+|       |   ttl = 'forever'                  |
+|       | )                                  |
 +-------+------------------------------------+
 
 ALTER TABLE ato SET 'ttl'='1s';