chore: apply suggestions from CR

GreptimeTeam · Dec 12, 2024 · c14ab76 · c14ab76
1 parent 3abb7dc
commit c14ab76
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/index/src/inverted_index/error.rs b/src/index/src/inverted_index/error.rs
@@ -76,6 +76,12 @@ pub enum Error {
         location: Location,
     },
 
+    #[snafu(display("Blob size too small"))]
+    BlobSizeTooSmall {
+        #[snafu(implicit)]
+        location: Location,
+    },
+
     #[snafu(display("Invalid footer payload size"))]
     InvalidFooterPayloadSize {
         #[snafu(implicit)]
@@ -236,7 +242,8 @@ impl ErrorExt for Error {
             | CommonIo { .. }
             | UnknownIntermediateCodecMagic { .. }
             | FstCompile { .. }
-            | InvalidFooterPayloadSize { .. } => StatusCode::Unexpected,
+            | InvalidFooterPayloadSize { .. }
+            | BlobSizeTooSmall { .. } => StatusCode::Unexpected,
 
             ParseRegex { .. }
             | ParseDFA { .. }

diff --git a/src/index/src/inverted_index/format/reader/footer.rs b/src/index/src/inverted_index/format/reader/footer.rs
@@ -18,7 +18,7 @@ use prost::Message;
 use snafu::{ensure, ResultExt};
 
 use crate::inverted_index::error::{
-    CommonIoSnafu, DecodeProtoSnafu, InvalidFooterPayloadSizeSnafu, Result,
+    BlobSizeTooSmallSnafu, CommonIoSnafu, DecodeProtoSnafu, InvalidFooterPayloadSizeSnafu, Result,
     UnexpectedFooterPayloadSizeSnafu, UnexpectedOffsetSizeSnafu,
     UnexpectedZeroSegmentRowCountSnafu,
 };
@@ -55,6 +55,11 @@ impl<R> InvertedIndexFooterReader<R> {
 
 impl<R: RangeReader> InvertedIndexFooterReader<R> {
     pub async fn metadata(&mut self) -> Result<InvertedIndexMetas> {
+        ensure!(
+            self.blob_size >= FOOTER_PAYLOAD_SIZE_SIZE,
+            BlobSizeTooSmallSnafu
+        );
+
         let footer_start = self.blob_size.saturating_sub(self.prefetch_size());
         let suffix = self
             .source