fix: show table names not complete from information_schema (#3417)

GreptimeTeam · Mar 1, 2024 · c1a3706 · c1a3706
1 parent 3cad9d9
commit c1a3706
Show file tree

Hide file tree

Showing 3 changed files with 303 additions and 279 deletions.
diff --git a/src/catalog/src/kvbackend/manager.rs b/src/catalog/src/kvbackend/manager.rs
@@ -17,7 +17,9 @@ use std::collections::BTreeSet;
 use std::sync::{Arc, Weak};
 
 use async_stream::try_stream;
-use common_catalog::consts::{DEFAULT_SCHEMA_NAME, INFORMATION_SCHEMA_NAME, NUMBERS_TABLE_ID};
+use common_catalog::consts::{
+    DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, INFORMATION_SCHEMA_NAME, NUMBERS_TABLE_ID,
+};
 use common_error::ext::BoxedError;
 use common_meta::cache_invalidator::{CacheInvalidator, CacheInvalidatorRef, Context};
 use common_meta::error::Result as MetaResult;
@@ -97,8 +99,7 @@ impl KvBackendCatalogManager {
                 catalog_manager: me.clone(),
                 catalog_cache: Cache::new(DEFAULT_CACHED_CATALOG),
                 information_schema_provider: Arc::new(InformationSchemaProvider::new(
-                    // The catalog name is not used in system_catalog, so let it empty
-                    String::default(),
+                    DEFAULT_CATALOG_NAME.to_string(),
                     me.clone(),
                 )),
             },

diff --git a/tests/cases/standalone/common/show/show_databases_tables.result b/tests/cases/standalone/common/show/show_databases_tables.result
@@ -20,6 +20,7 @@ show tables;
 +---------------------------------------+
 | Tables                                |
 +---------------------------------------+
+| build_info                            |
 | character_sets                        |
 | check_constraints                     |
 | collation_character_set_applicability |
@@ -31,13 +32,15 @@ show tables;
 | events                                |
 | files                                 |
 | global_status                         |
+| greptime_region_peers                 |
 | key_column_usage                      |
 | optimizer_trace                       |
 | parameters                            |
 | partitions                            |
 | profiling                             |
 | referential_constraints               |
 | routines                              |
+| runtime_metrics                       |
 | schema_privileges                     |
 | schemata                              |
 | session_status                        |