fix: carry dbname from frontend to datanode
#2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuiyisong
requested review from
sunng87,
MichaelScofield,
waynexia,
zhongzc and
fengys1996
sunng87
reviewed
Oct 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2520 +/- ##
===========================================
- Coverage 85.32% 84.98% -0.35%
===========================================
Files 730 730
Lines 116311 116520 +209
===========================================
- Hits 99240 99020 -220
- Misses 17071 17500 +429 |
…pdate proto version
sunng87
approved these changes
Oct 7, 2023
zhongzc
reviewed
Oct 8, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: add dbname in region request header for tracking purpose * chore: fix handle read * chore: add write meter * chore: add meter-core to dep * chore: add converter between RegionRequestHeader and QueryContext & update proto version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
We introduced region server since v0.4, which changed the api between frontend and datanode. This pr mainly fixes losing
dbnamefrom frontend to datanode.span_idinself.do_requestsignature since its all0now. We should usespan_idin ctx if later come into usage.dbnamein task context within datafusion instead oftrace_id.trace_idis now retrieved using task local.write_meterfor logging inserts.TODO:
dbnamein region request header for tracking purpose greptime-proto#107Checklist
Refer to a related PR or issue link (optional)