refactor!: compare with origin bytes during the transactions #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2538 +/- ##
===========================================
- Coverage 85.34% 84.98% -0.37%
===========================================
Files 737 737
Lines 117409 117561 +152
===========================================
- Hits 100206 99911 -295
- Misses 17203 17650 +447 |
WenyXu
force-pushed
the
refactor/use-remote-bytes
branch
from
be4c6fa to
06c14b2
Compare
WenyXu
force-pushed
the
refactor/use-remote-bytes
branch
5 times, most recently
from
b32f05b to
d057b49
Compare
|
@MichaelScofield PTAL |
WenyXu
force-pushed
the
refactor/use-remote-bytes
branch
from
d057b49 to
f6a02fe
Compare
MichaelScofield
approved these changes
Oct 9, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…eTeam#2538) * refactor: compare with origin bytes during the transaction * refactor: use serialize_str instead * Update src/common/meta/src/key.rs Co-authored-by: JeremyHi <[email protected]> * chore: apply suggestions from CR --------- Co-authored-by: JeremyHi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
DeserializedValueWithBytesstruct.This PR modifies the persistent structs used in meta's procedures, ensuring all old procedures are finished before starting a new version of metasrv.
Checklist
Refer to a related PR or issue link (optional)
close #2198