-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom storage for every table(initial) #2605
feat: support custom storage for every table(initial) #2605
Conversation
I rebased the error: use of deprecated method `chrono::DateTime::<Tz>::timestamp_nanos`: use `timestamp_nanos_opt()` instead
--> src/common/time/src/timestamp.rs:66:41
|
66 | TimeUnit::Nanosecond => now.timestamp_nanos(),
| ^^^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` instead
--> src/common/time/src/timestamp.rs:301:29
|
301 | if let Ok(ts) = Utc.datetime_from_str(s, "%Y-%m-%d %H:%M:%S%.fZ") {
| ^^^^^^^^^^^^^^^^^ |
@NiwakaDev Maybe caused by a newer opendal version. Our |
826a83c
to
189eb79
Compare
189eb79
to
527beeb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2605 +/- ##
===========================================
- Coverage 85.33% 84.81% -0.53%
===========================================
Files 737 739 +2
Lines 118042 118707 +665
===========================================
- Hits 100736 100683 -53
- Misses 17306 18024 +718 |
let mut storage_types = Vec::with_capacity(4); | ||
storage_types.push(StorageType::File); | ||
if let Ok(bucket) = env::var("GT_S3_BUCKET") { | ||
if !bucket.is_empty() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
greptimedb/.github/workflows/develop.yml
Lines 178 to 184 in 3217b56
GT_S3_BUCKET: ${{ secrets.S3_BUCKET }} | |
GT_S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }} | |
GT_S3_ACCESS_KEY: ${{ secrets.S3_ACCESS_KEY }} | |
GT_S3_REGION: ${{ secrets.S3_REGION }} | |
UNITTEST_LOG_DIR: "__unittest_logs" | |
- name: Codecov upload | |
uses: codecov/codecov-action@v2 |
Settings for S3 reside, but it seems like bucket is empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The S3_BUCKET
is only available in this repo's secrets. A PR from a forked repo can't get this secret. So we run the test in the CI after the PR is merged.
This feature impacts many modules and contains breaking changes. I'd like to merge it gradually (in several PRs) so we can review and test it carefully. Could you please separate it into smaller PRs? e.g.
|
@@ -43,9 +43,10 @@ sync_write = false | |||
[storage] | |||
# The working home directory. | |||
data_home = "/tmp/greptimedb/" | |||
# global_store = "File" | |||
# Storage type. | |||
[[storage.store]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change. storage.store
is a little odd. We'd better find out a new name or revisit the storage config later.
Sorry for submitting the large PR. Your point is correct😅. I opened a new PR(#2621), and please review it. |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR addresses a part of #919.
Here's an example of using this feature.
Note that this PR doesn't implement:
Checklist
Refer to a related PR or issue link (optional)
Not close #919 yet.