Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: created_on of RawTableMeta should be init with Utc::now #2710

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: created_on of RawTableMeta should be init with Utc::now #2710

merged 1 commit into from
Nov 8, 2023

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Nov 8, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This fixes #2632.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2710 (7d91631) into develop (c79bb5a) will decrease coverage by 0.44%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2710      +/-   ##
===========================================
- Coverage    85.23%   84.79%   -0.44%     
===========================================
  Files          763      763              
  Lines       122900   122949      +49     
===========================================
- Hits        104751   104253     -498     
- Misses       18149    18696     +547     

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun enabled auto-merge November 8, 2023 08:35
@fengjiachun fengjiachun added this pull request to the merge queue Nov 8, 2023
Merged via the queue into GreptimeTeam:develop with commit 69ee2c3 Nov 8, 2023
12 checks passed
@tisonkun tisonkun deleted the fix-created_on branch November 8, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"created_on" in table info is set to UTC time 0
4 participants