feat: handle scan request on metric engine #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2793 +/- ##
===========================================
- Coverage 84.49% 84.38% -0.11%
===========================================
Files 729 732 +3
Lines 113510 114130 +620
===========================================
+ Hits 95913 96313 +400
- Misses 17597 17817 +220 |
Signed-off-by: Ruihang Xia <[email protected]>
fengjiachun
reviewed
Nov 23, 2023
evenyag
reviewed
Nov 23, 2023
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
approved these changes
Nov 24, 2023
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
killme2008
reviewed
Nov 24, 2023
| .contains_key(®ion_id); | ||
|
|
||
| if is_reading_physical_region { | ||
| info!( |
There was a problem hiding this comment.
The log level is too high, debug would be better.
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Handle
ScanRequeston metric engine. Request to logical region will be transformed to request to physical region, and request to physical region is proxied to mito directly.Checklist
Refer to a related PR or issue link (optional)