-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(mito): scan SSTs and memtables in parallel #2852
Merged
fengjiachun
merged 33 commits into
GreptimeTeam:develop
from
evenyag:perf/parallel-scan
Dec 11, 2023
Merged
perf(mito): scan SSTs and memtables in parallel #2852
fengjiachun
merged 33 commits into
GreptimeTeam:develop
from
evenyag:perf/parallel-scan
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01e0df2.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2852 +/- ##
===========================================
- Coverage 84.73% 84.44% -0.30%
===========================================
Files 749 754 +5
Lines 117900 118785 +885
===========================================
+ Hits 99900 100303 +403
- Misses 18000 18482 +482 |
fengjiachun
reviewed
Dec 8, 2023
WenyXu
reviewed
Dec 8, 2023
WenyXu
approved these changes
Dec 11, 2023
fengjiachun
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR scans SSTs and memtables in parallel. Scanning each file or memtable is still sequential.
The implementation of parallel scan is quite intuitive: It spawns a scan task for each data source and yields the scanned batch to the merge reader via a channel.
There are two new options for parallel scan.
1/4
of CPU cores32
TSBS results
Larger parallelism might not always help as the total number of SSTs to scan might be less than the parallelism.
Checklist
Refer to a related PR or issue link (optional)