Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use explicitly set table id #2945

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat: use explicitly set table id #2945

merged 3 commits into from
Dec 21, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

make standalone table metadata allocator able to use explicitly set table id

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (97c3755) 85.81% compared to head (3fd7a29) 85.28%.
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2945      +/-   ##
===========================================
- Coverage    85.81%   85.28%   -0.53%     
===========================================
  Files          767      775       +8     
  Lines       123745   124258     +513     
===========================================
- Hits        106191   105979     -212     
- Misses       17554    18279     +725

@WenyXu
Copy link
Member

WenyXu commented Dec 20, 2023

There are some conflicts.

@MichaelScofield MichaelScofield force-pushed the feat/explicitly-set-tableid branch from 06f66ec to df63d3e Compare December 20, 2023 07:15
@MichaelScofield
Copy link
Collaborator Author

@WenyXu @fengjiachun PTAL

@MichaelScofield
Copy link
Collaborator Author

@WenyXu PTAL

fengjiachun
fengjiachun approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 8776b12 Dec 21, 2023
13 checks passed
@MichaelScofield MichaelScofield deleted the feat/explicitly-set-tableid branch December 21, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@WenyXu WenyXu WenyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelScofield @WenyXu @fengjiachun